Skip to content

gh-109566: Run buildbot tests with --fail-rerun #109567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 19, 2023

@vstinner
Copy link
Member Author

Since tests are now re-run in fresh processes, it's more likely that they pass when being re-run in verbose mode.

IMO we should make tests fail if a test failed and then succeeded when re-run: we should not silence tests failing randomly.

See also: https://discuss.python.org/t/consider-downgrading-windows-32-bit-from-tier-1-to-tier-2-or-tier-3-in-python-3-13/33719/37

@vstinner vstinner requested a review from a team as a code owner September 19, 2023 11:46
@vstinner
Copy link
Member Author

Hum, the two GHA Windows jobs run directly PCbuild\rt.bat, instead of Tools\buildbot\test.bat. I moved the two --fail options in rt.bat, so the GHA Windows jobs use them.

@vstinner vstinner merged commit 67d9363 into python:main Sep 19, 2023
@vstinner vstinner deleted the buildbot_fail_rerun branch September 19, 2023 13:50
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant