Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104469: Convert _testcapi/vectorcall_limited.c to use AC #109691

Merged
merged 2 commits into from
Sep 25, 2023
Merged

gh-104469: Convert _testcapi/vectorcall_limited.c to use AC #109691

merged 2 commits into from
Sep 25, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 21, 2023 •
edited by bedevere-app bot
Loading

@vstinner @nahyeon-an
pythongh-104469: Convert _testcapi/vectorcall_limited.c to use AC
8004d79 
Co-Authored-By: nahyeon <55136494+nahyeon-an@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this pull request Sep 21, 2023
Closed
@vstinner vstinner mentioned this pull request Sep 21, 2023
Merged
@vstinner
Copy link
Member Author

cc @corona10

@vstinner
Copy link
Member Author

cc @erlend-aasland

vstinner
vstinner commented Sep 25, 2023
View reviewed changes
Copy link
Member Author

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before and after, the two functions use METH_O calling convention. Nothing crazy, there is no generated code to parse arguments, since the only argument is declared as callable: object in both cases.

@vstinner vstinner merged commit 8c521f0 into python:main Sep 25, 2023
21 checks passed
@vstinner vstinner deleted the testcapi_vectorcall_limited branch September 25, 2023 11:24
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @nahyeon-an @csm10495
pythongh-104469: Convert _testcapi/vectorcall_limited.c to use AC (py…
4ede466 
…thon#109691)

Co-authored-by: nahyeon <55136494+nahyeon-an@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @nahyeon-an @Glyphack
pythongh-104469: Convert _testcapi/vectorcall_limited.c to use AC (py…
062b6c5 
…thon#109691)

Co-authored-by: nahyeon <55136494+nahyeon-an@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner