Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-109190: Copyedit 3.12 What's New: Bytecode #109821

Merged
merged 7 commits into from
Sep 28, 2023
Merged

GH-109190: Copyedit 3.12 What's New: Bytecode #109821

merged 7 commits into from
Sep 28, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 25, 2023 •
edited by hugovk
Loading

📚 Documentation preview 📚: https://cpython-previews--109821.org.readthedocs.build/en/109821/whatsnew/3.12.html

@AA-Turner AA-Turner added the needs backport to 3.12 bug and security fixes label Sep 25, 2023
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 25, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 25, 2023
Closed
hugovk
hugovk reviewed Sep 25, 2023
View reviewed changes
@AA-Turner AA-Turner requested a review from hugovk September 27, 2023 14:05
hugovk
hugovk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the INTRINSIC typo :)

Let's merge, we can update later if END_SEND is ever documented (via #107457).

hugovk
hugovk reviewed Sep 27, 2023
View reviewed changes
Doc/whatsnew/3.12.rst Outdated
@@ -1032,6 +1057,8 @@ CPython bytecode changes
* Add the :opcode:`LOAD_SUPER_ATTR` instruction. (Contributed by Carl Meyer and
Vladimir Matveev in :gh:`103497`.)

* Add the :opcode:`RETURN_CONST` instruction. (:gh:`101632`.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add credit for issue #101632 / PR #101633?

Suggested change
* Add the :opcode:`RETURN_CONST` instruction. (:gh:`101632`.)
* Add the :opcode:`RETURN_CONST` instruction. (Contributed by penguin_wwy in :gh:`101632`.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@penguin-wwy please could we check how you'd like to be credited for this change? (I have a slight preference against using usernames in the documentation!)

A

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks, if possible, then just use Wenyang Wang.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AA-Turner
Merge branch 'main' into docs/whatsnew/bytecode
6ddc852 
# Conflicts:
#	Doc/whatsnew/3.12.rst
hugovk
hugovk reviewed Sep 28, 2023
View reviewed changes
@hugovk hugovk enabled auto-merge (squash) September 28, 2023 04:29
@hugovk hugovk merged commit 526380e into python:main Sep 28, 2023
@miss-islington
Copy link
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 526380e28644236bde9e41b949497ca1ee22653f 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Sep 28, 2023
@AA-Turner
[3.12] pythonGH-109190: Copyedit 3.12 What's New: Bytecode (pythonGH-…
f8cb762 
…109821)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit 526380e)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 28, 2023

GH-110047 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 28, 2023
Yhg1s pushed a commit that referenced this pull request Sep 28, 2023
@AA-Turner
[3.12] GH-109190: Copyedit 3.12 What's New: Bytecode (GH-109821) (#11…
335e3d5 
…0047)

.
(cherry picked from commit 526380e)
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 29, 2023
@AA-Turner @hugovk @csm10495
pythonGH-109190: Copyedit 3.12 What's New: Bytecode (python#109821)
39eda99 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@AA-Turner AA-Turner deleted the docs/whatsnew/bytecode branch September 29, 2023 08:16
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @hugovk @Glyphack
pythonGH-109190: Copyedit 3.12 What's New: Bytecode (python#109821)
0668232 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@MatthieuDartiailh MatthieuDartiailh MatthieuDartiailh left review comments

@penguin-wwy penguin-wwy penguin-wwy left review comments

@ambv ambv Awaiting requested review from ambv

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@markshannon markshannon Awaiting requested review from markshannon

Assignees

@hugovk hugovk

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AA-Turner @miss-islington @hugovk @MatthieuDartiailh @penguin-wwy