gh-104638: make TarFile.extraction_filter future release references more clear
#109908
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rences more clear
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
nineteendo
reviewed
May 19, 2024
| @@ -557,7 +557,7 @@ be finalized; only the internally used file object will be closed. See the | |||
| and fall back to the :func:`fully_trusted <fully_trusted_filter>` filter, | |||
| whose dangerous behavior matches previous versions of Python. | |||
|
|
|||
| In Python 3.14+, leaving ``extraction_filter=None`` will cause | |||
| In Python 3.14, leaving ``extraction_filter=None`` will cause | |||
There was a problem hiding this comment.
Isn't that a bit redundant?
Suggested change
| In Python 3.14, leaving ``extraction_filter=None`` will cause | |
| Leaving ``extraction_filter=None`` will cause |
And can't we merge this with the previous paragraph?
|
Thanks for the PR, made redundant by #122002 which removed this bit of text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for
TarFile.extraction_filterfuture releases are referenced as "In python 3.14+ ..." which may be confusing thus plus symbol is removed.📚 Documentation preview 📚: https://cpython-previews--109908.org.readthedocs.build/