Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110052: Fix faulthandler for freed tstate #110069

Merged
merged 1 commit into from
Sep 29, 2023
Merged

gh-110052: Fix faulthandler for freed tstate #110069

merged 1 commit into from
Sep 29, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 29, 2023 •
edited by bedevere-app bot
Loading

faulthandler now detected freed interp and freed tstate, and no longer dereference them.

@vstinner
pythongh-110052: Fix faulthandler for freed tstate
585a1a4 
faulthandler now detected freed interp and freed tstate, and no
longer dereference them.
@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2023
Closed
@vstinner vstinner enabled auto-merge (squash) September 29, 2023 01:38
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 29, 2023
@vstinner vstinner merged commit 2e37a38 into python:main Sep 29, 2023
@vstinner vstinner deleted the faulthandler branch September 29, 2023 02:04
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2e37a38bcbfbe1357436e030538290e7d00b668d 3.12

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2e37a38bcbfbe1357436e030538290e7d00b668d 3.11

vstinner added a commit to vstinner/cpython that referenced this pull request Sep 29, 2023
@vstinner
pythongh-110052: Fix faulthandler for freed tstate (python#110069)
faf7d4a 
faulthandler now detected freed interp and freed tstate, and no
longer dereference them.

(cherry picked from commit 2e37a38)
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2023

GH-110071 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 29, 2023
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2023

GH-110072 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 29, 2023
vstinner added a commit that referenced this pull request Sep 29, 2023
@vstinner
[3.11] gh-110052: Fix faulthandler for freed tstate (#110069) (#110072)
615d7fc 
gh-110052: Fix faulthandler for freed tstate (#110069)

faulthandler now detected freed interp and freed tstate, and no
longer dereference them.

Backport to 3.11: add pycore_pymem.h include to traceback.c.

(cherry picked from commit 2e37a38)
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@vstinner
[3.12] gh-110052: Fix faulthandler for freed tstate (#110069) (#110071)
d0641ab 
gh-110052: Fix faulthandler for freed tstate (#110069)

faulthandler now detected freed interp and freed tstate, and no
longer dereference them.

(cherry picked from commit 2e37a38)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110052: Fix faulthandler for freed tstate (python#110069)
6be8ef2 
faulthandler now detected freed interp and freed tstate, and no
longer dereference them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @miss-islington