Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110152: regrtest handles cross compilation and HOSTRUNNER #110156

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 30, 2023

  • _add_python_opts() now handles cross compilation and HOSTRUNNER.
  • display_header() now tells if Python is cross-compiled, display HOSTRUNNER, and get the host platform.
  • Remove Tools/scripts/run_tests.py script.
  • Remove "make hostrunnertest": use "make buildbottest" or "make test" instead.

@vstinner
Copy link
Member Author

!buildbot wasm

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit cd4bf78 🤖

The command will test the builders whose names match following regular expression: wasm

The builders matched are:

  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten node (dynamic linking) PR

@vstinner
Copy link
Member Author

wasm32-emscripten node (pthreads) PR:

make buildbottest 'TESTOPTS=-j2  --junit-xml test-results.xml -j2 ${BUILDBOT_TESTOPTS}' TESTPYTHONOPTS= TESTTIMEOUT=1200
(...)
_PYTHON_HOSTRUNNER='/opt/emsdk/node/current/bin/node --experimental-wasm-bigint --experimental-wasm-threads --experimental-wasm-bulk-memory' _PYTHON_PROJECT_BASE=/opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-pthreads/build/build_oot/host _PYTHON_HOST_PLATFORM=emscripten-wasm32 PYTHONPATH=/opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-pthreads/build/build_oot/host/build/lib.emscripten-wasm32-3.13:../../Lib _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata__emscripten_wasm32-emscripten ../build/python  -m test --slow-ci --timeout=1200 -j2  --junit-xml test-results.xml -j2 
+ ../build/python -u -W default -bb -m test --slow-ci --timeout=1200 -j2 --junit-xml test-results.xml -j2 --python '/opt/emsdk/node/current/bin/node --experimental-wasm-bigint --experimental-wasm-threads --experimental-wasm-bulk-memory python.js' --dont-add-python-opts
== CPython 3.13.0a0 (heads/refs/pull/110156/merge-dirty:752dc07d2d, Sep 30 2023, 20:25:56) [GCC 9.4.0]
== Linux-5.15.0-1019-azure-x86_64-with-glibc2.31 little-endian
== Python build: release
== cwd: /opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-pthreads/build/build_oot/host/build/test_python_worker_1799820æ
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
== resources (10): audio, cpu, curses, decimal, gui, largefile, network, subprocess, urlfetch, walltime
== cross compiled: Yes
== host python: /opt/emsdk/node/current/bin/node --experimental-wasm-bigint --experimental-wasm-threads --experimental-wasm-bulk-memory python.js
== host platform: Emscripten-3.1.22-wasm32-32bit

wasm32-emscripten node (dynamic linking) PR:

make buildbottest 'TESTOPTS=-j2  --junit-xml test-results.xml -j2 ${BUILDBOT_TESTOPTS}' TESTPYTHONOPTS= TESTTIMEOUT=1200
(...)
_PYTHON_HOSTRUNNER='/opt/emsdk/node/current/bin/node --experimental-wasm-bigint' _PYTHON_PROJECT_BASE=/opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-dl/build/build_oot/host _PYTHON_HOST_PLATFORM=emscripten-wasm32 PYTHONPATH=/opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-dl/build/build_oot/host/build/lib.emscripten-wasm32-3.13:../../Lib _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata__emscripten_wasm32-emscripten ../build/python  -m test --slow-ci --timeout=1200 -j2  --junit-xml test-results.xml -j2 
+ ../build/python -u -W default -bb -m test --slow-ci --timeout=1200 -j2 --junit-xml test-results.xml -j2 --python '/opt/emsdk/node/current/bin/node --experimental-wasm-bigint python.js' --dont-add-python-opts
== CPython 3.13.0a0 (heads/refs/pull/110156/merge-dirty:752dc07d2d, Sep 30 2023, 20:22:43) [GCC 9.4.0]
== Linux-5.15.0-1019-azure-x86_64-with-glibc2.31 little-endian
== Python build: release
== cwd: /opt/buildbot/bcannon-wasm/pull_request.bcannon-wasm.emscripten-node-dl/build/build_oot/host/build/test_python_worker_1786909æ
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
== resources (10): audio, cpu, curses, decimal, gui, largefile, network, subprocess, urlfetch, walltime
== cross compiled: Yes
== host python: /opt/emsdk/node/current/bin/node --experimental-wasm-bigint python.js
== host platform: Emscripten-3.1.22-wasm32-32bit

@vstinner
Copy link
Member Author

Oh, wasm32-wasi PR failed on test.pythoninfo:

Checked 106 modules (74 built-in, 0 shared, 19 n/a on wasi-wasm32, 1 disabled, 12 missing, 0 failed on import)
wasmtime run --env PYTHONPATH=/build_oot/host/build/lib.wasi-wasm32-3.13:/Lib --mapdir /::../.. -- ./python.wasm -m test.pythoninfo
Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python
Python runtime state: preinitialized
make: *** [Makefile:1990: pythoninfo] Error 1

@vstinner
Copy link
Member Author

Oh, wasm32-wasi PR failed on test.pythoninfo

Fixed by PR gh-110161.

* _add_python_opts() now handles cross compilation and HOSTRUNNER.
* display_header() now tells if Python is cross-compiled, display
  HOSTRUNNER, and get the host platform.
* Remove Tools/scripts/run_tests.py script.
* Remove "make hostrunnertest": use "make buildbottest"
  or "make test" instead.
@vstinner vstinner enabled auto-merge (squash) September 30, 2023 22:14
@vstinner vstinner merged commit 53eb9a6 into python:main Sep 30, 2023
@vstinner vstinner deleted the regrtest_hostrunner branch September 30, 2023 22:37
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ython#110156)

* _add_python_opts() now handles cross compilation and HOSTRUNNER.
* display_header() now tells if Python is cross-compiled, display
  HOSTRUNNER, and get the host platform.
* Remove Tools/scripts/run_tests.py script.
* Remove "make hostrunnertest": use "make buildbottest"
  or "make test" instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants