Skip to content

Remove unused Misc/requirements-test.txt #110240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 2, 2023

In 2020, PR #19909 added Misc/requirements-test.txt and installed it as part of .github/workflows/coverage.yml and .travis.yml.

In 2021, however, PRs #25679 and #30257 removed those CI files, so Misc/requirements-test.txt is unused.

Let's remove it.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 1001233 into python:main Oct 3, 2023
@hugovk hugovk deleted the rm-requirements-test.txt branch October 3, 2023 05:01
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2023

GH-110253 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
(cherry picked from commit 1001233)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 3, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 3, 2023

GH-110254 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 3, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2023
(cherry picked from commit 1001233)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Oct 3, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Oct 3, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants