gh-109286: Updated macOS SQLite installer to 3.43.1 #110374
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
…li/cpython into macOS-SQLite-installer-upgrade
Misc/NEWS.d/next/macOS/2023-10-04-23-38-24.gh-issue-109286.1ZLMaq.rst
Outdated
Show resolved
Hide resolved
Before doing the Windows PRs, please take a close look at the earlier Windows PRs; your PR should look very similar to these: |
erlend-aasland
added
needs backport to 3.11
Sounds good, sorry about that. I had messed around with those lines because I was getting a trailing white space error, and then in my previous pr someone had asked me to realign the indentation of extra_cflags, so I thought it was accidentally over-indented. Just out of curiosity, why is the extra indentation preferred in that context? |
|
Why was this closed? |
It's not that the extra indentation is preferred; the point is that any change should be as isolated as possible. Any style changes (or other unrelated changes) should be left out. |
It was an accident. I was asked to separate the changes for macOS and Windows into two separate PRs, and despite using different branches for each set of changes, GitHub was not allowing me to create separate PRs for each, so I submitted the PR with the macOS changes, then deleted that branch on my GitHub page so that the changes made in that branch would not be included in my PR for the Windows changes, then submitted the PR for the Windows changes. I didn't realize that deleting the branch on my personal page would close this PR and that was the only work around I could think of to isolate the changes for the two operating systems since Github was seemingly not allowing me to isolate the changes made in each branch into two separate PRs. If you merge the PR I made for the Windows SQLite installer upgrade I'll submit a new PR for the macOS installer upgrades, but other than deleting the branch locally I'm not sure how I can isolate those changes as requested. Sorry for the hassle. |
|
Can you please reopen this PR? |
I'm prevented from doing so because the branch was deleted, re-uploading it doesn't seem to help either. All the requested changes were saved on my local branch though so I'll just create a new pr. Again, sorry for the hassle. |
I updated the macOS SQLite installer, all changes were made in the build-installer.py file. I'll be doing the Windows installer next in a separate PR as requested.