gh-110378: Close invalid generators in contextmanager and asynccontextmanager #110499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contextmanager contextmanager and asynccontextmanager context managers now close an invalid underlying generator object that yields more then one value.
serhiy-storchaka
added
needs backport to 3.11
ambv
reviewed
Oct 9, 2023
Comment on lines
+152
to
+155
| try: | ||
| raise RuntimeError("generator didn't stop") | ||
| finally: | ||
| self.gen.close() |
There was a problem hiding this comment.
👍🏻
I sometimes use the try:finally: construct around flow breaking instructions as well. Here it nicely chains exceptions if self.gen.close() raises.
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
…contextmanager (pythonGH-110499) contextmanager and asynccontextmanager context managers now close an invalid underlying generator object that yields more then one value. (cherry picked from commit 96fed66) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
…contextmanager (pythonGH-110499) contextmanager and asynccontextmanager context managers now close an invalid underlying generator object that yields more then one value. (cherry picked from commit 96fed66) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-110588 is a backport of this pull request to the 3.12 branch. |
|
GH-110589 is a backport of this pull request to the 3.11 branch. |
ambv
added a commit
that referenced
this pull request
Oct 10, 2023
…ccontextmanager (GH-110499) (#110589) contextmanager and asynccontextmanager context managers now close an invalid underlying generator object that yields more then one value. (cherry picked from commit 96fed66) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…contextmanager (pythonGH-110499) contextmanager and asynccontextmanager context managers now close an invalid underlying generator object that yields more then one value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextmanager and asynccontextmanager context managers now close an invalid underlying generator object that yields more then one value.
test_contextlib_asyncproduces severalRuntimeWarnings #110378