Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110938: Fix error messages for indented blocks with functions and classes with generic type parameters #110973

Merged
merged 1 commit into from
Oct 17, 2023
Merged

gh-110938: Fix error messages for indented blocks with functions and classes with generic type parameters #110973

merged 1 commit into from
Oct 17, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 17, 2023 •
edited by bedevere-app bot
Loading

@pablogsal
pythongh-110938: Fix error messages for indented blocks with function…
3925cd2 
…s and classes with generic type parameters

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Oct 17, 2023
Closed
@pablogsal pablogsal added the needs backport to 3.12 bug and security fixes label Oct 17, 2023
@pablogsal pablogsal merged commit 24e4ec7 into python:main Oct 17, 2023
26 checks passed
@pablogsal pablogsal deleted the gh-110938 branch October 17, 2023 12:45
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24e4ec7766fd471deb5b7e5087f0e7dba8576cfb 3.12

@JelleZijlstra
Copy link
Member

Working on the backport

@JelleZijlstra JelleZijlstra mentioned this pull request Oct 17, 2023
Merged
@bedevere-app
Copy link

bedevere-app bot commented Oct 17, 2023

GH-110990 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 17, 2023
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 17, 2023
@pablogsal @JelleZijlstra
[3.12] pythongh-110938: Fix error messages for indented blocks with f…
5e570c2 
…unctions and classes with generic type parameters (pythonGH-110973)

(cherry picked from commit 24e4ec7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
JelleZijlstra added a commit that referenced this pull request Oct 18, 2023
@JelleZijlstra @pablogsal
[3.12] gh-110938: Fix error messages for indented blocks with functio… (
2bca5f4 
#110990)

[3.12] gh-110938: Fix error messages for indented blocks with functions and classes with generic type parameters (GH-110973)
(cherry picked from commit 24e4ec7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@pablogsal @aisk
pythongh-110938: Fix error messages for indented blocks with function…
3f3f5a8 
…s and classes with generic type parameters (python#110973)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-110938: Fix error messages for indented blocks with function…
199ff93 
…s and classes with generic type parameters (python#110973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid_def_raw and invalid_class_def_raw rules do not account for type parameters
3 participants
@pablogsal @JelleZijlstra @lysnikolaou