-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-101100: Fix Sphinx warnings for fileno
#111118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not some of references be to io.IOBase.fileno
?
Good idea, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I once thought about fixing all wild references to file methods, but shelved the idea. If you're going to do it, it's best to do it in one PR rather than opening a PR for every method. Then you will be sure that they are unified.
But this PR LGTM.
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
(cherry picked from commit 96cbd1e) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 96cbd1e) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
GH-111226 is a backport of this pull request to the 3.12 branch. |
GH-111227 is a backport of this pull request to the 3.11 branch. |
Most of these references to
fileno
are relating to generic objects, so add!
to them. Add the full reference to:meth:`~fileinput.fileno`
.Also fix Sphinx warnings in
Doc/library/bz2.rst
by documenting the missing methods using their docstrings.📚 Documentation preview 📚: https://cpython-previews--111118.org.readthedocs.build/