Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-76785: Return an "excinfo" Object From Interpreter.run() #111573

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Oct 31, 2023

@ericsnowcurrently ericsnowcurrently changed the title gh-76785: Return an ExceptionSnapshot from Interpreter.run(). gh-76785: Return an ExceptionSnapshot From Interpreter.run() Oct 31, 2023
@ericsnowcurrently ericsnowcurrently force-pushed the interp-run-return-exc-info branch 4 times, most recently from 5443e2c to 3f56dbf Compare November 2, 2023 16:18
ericsnowcurrently added a commit that referenced this pull request Nov 6, 2023
…1715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in gh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see gh-111572/gh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with gh-111572, which I may, in turn, combine with gh-111573.  We'll see.)
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
…ythongh-111715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573.  We'll see.)
@ericsnowcurrently ericsnowcurrently changed the title gh-76785: Return an ExceptionSnapshot From Interpreter.run() gh-76785: Return an "excinfo" Object From Interpreter.run() Nov 23, 2023
@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review November 23, 2023 00:48
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) November 23, 2023 00:48
@ericsnowcurrently ericsnowcurrently merged commit 9e56eed into python:main Nov 23, 2023
29 checks passed
@ericsnowcurrently ericsnowcurrently deleted the interp-run-return-exc-info branch November 23, 2023 00:55
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ythongh-111715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573.  We'll see.)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ythongh-111715)

I added _Py_excinfo to the internal API (and added its functions in Python/errors.c) in pythongh-111530 (9322ce9).  Since then I've had a nagging sense that I should have added the type and functions in its own PR.  While I do plan on using _Py_excinfo outside crossinterp.c very soon (see pythongh-111572/pythongh-111573), I'd still feel more comfortable if the _Py_excinfo stuff went in as its own PR.  Hence, here we are.

(FWIW, I may combine that with pythongh-111572, which I may, in turn, combine with pythongh-111573.  We'll see.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant