Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111789: Simplify import.c by using PyDict_GetItemRef() #111979

Merged
merged 2 commits into from
Nov 14, 2023
Merged

gh-111789: Simplify import.c by using PyDict_GetItemRef() #111979

merged 2 commits into from
Nov 14, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 11, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 11, 2023
Closed
vstinner
vstinner approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just proposed a minor suggestion :-)

resolve_name() changes are non-trivial, but code handling (X)DECREF is at the end, so it's not too hard to review.

Python/import.c Outdated Show resolved Hide resolved
@serhiy-storchaka @vstinner
Update Python/import.c
e4b181a 
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka serhiy-storchaka merged commit 9536562 into python:main Nov 14, 2023
28 checks passed
@serhiy-storchaka serhiy-storchaka deleted the use-dict_getitemref-import branch November 14, 2023 09:29
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-111789: Simplify import.c by using PyDict_GetItemRef() (pyth…
475b735 
…onGH-111979)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-111789: Simplify import.c by using PyDict_GetItemRef() (pyth…
e120eb9 
…onGH-111979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @vstinner