Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112252: Fix error on unset $OSNAME in venv/activate #112253

Merged
merged 1 commit into from
Nov 21, 2023
Merged

gh-112252: Fix error on unset $OSNAME in venv/activate #112253

merged 1 commit into from
Nov 21, 2023
+1 −1

Conversation

jamesturk
Copy link
Contributor

@jamesturk jamesturk commented Nov 19, 2023 •
edited by bedevere-app bot
Loading

Fixes usage of potentially unset $OSNAME environment variable in venv/activate script.

@jamesturk jamesturk requested a review from vsajip as a code owner November 19, 2023 00:22
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Nov 19, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 19, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Nov 19, 2023
Closed
sobolevn
sobolevn approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@vsajip vsajip merged commit e1540ae into python:main Nov 21, 2023
@vsajip vsajip added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Nov 21, 2023
@miss-islington-app
Copy link

Thanks @jamesturk for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @jamesturk for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @jamesturk and @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e1540ae74d1fce62f53e25838ba21746ba5d8444 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2023
@jamesturk @miss-islington
pythongh-112252: Fix error on unset $OSNAME in venv/activate (pythonG…
2433577 
…H-112253)

(cherry picked from commit e1540ae)

Co-authored-by: James Turk <dev@jamesturk.net>
@bedevere-app
Copy link

bedevere-app bot commented Nov 21, 2023

GH-112297 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 21, 2023
serhiy-storchaka pushed a commit that referenced this pull request Dec 25, 2023
@miss-islington @jamesturk
[3.12] gh-112252: Fix error on unset $OSNAME in venv/activate (GH-112253
2c07540 
) (GH-112297)

(cherry picked from commit e1540ae)

Co-authored-by: James Turk <dev@jamesturk.net>
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Dec 25, 2023
@serhiy-storchaka
Copy link
Member

It does not need a backport on 3.11.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@jamesturk @aisk
pythongh-112252: Fix error on unset $OSNAME in venv/activate (pythonG…
4d72496 
…H-112253)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@jamesturk @Glyphack
pythongh-112252: Fix error on unset $OSNAME in venv/activate (pythonG…
79a8de3 
…H-112253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees

@vsajip vsajip

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesturk @serhiy-storchaka @vsajip @sobolevn