Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string #112407

Merged
merged 5 commits into from
Nov 26, 2023
Merged

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string #112407

merged 5 commits into from
Nov 26, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 25, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 25, 2023
Closed
ericvsmith
ericvsmith approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the magic number needs to increase, because this is a backwards compatible change, but I suppose it doesn't really matter.

In any event, this looks good to me. Thanks!

iritkatriel
iritkatriel commented Nov 26, 2023
View reviewed changes
Lib/importlib/_bootstrap_external.py Outdated Show resolved Hide resolved
Lib/importlib/_bootstrap_external.py Outdated Show resolved Hide resolved
@iritkatriel iritkatriel merged commit fb202af into python:main Nov 26, 2023
30 checks passed
@thatbirdguythatuknownot thatbirdguythatuknownot mentioned this pull request Dec 19, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-99606: Make code generated for an empty f-string identical t…
9b6fd48 
…o that of a normal empty string (python#112407)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-99606: Make code generated for an empty f-string identical t…
9cfdb7d 
…o that of a normal empty string (python#112407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bytecode for empty f-string != bytecode for empty normal string
2 participants
@iritkatriel @ericvsmith