gh-112769: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix #112771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th non-int suffix zlib-ng defines the version as "1.3.0.zlib-ng". https://github.com/zlib-ng/zlib-ng/blob/f3211aba349a1d4781d0d41cb00d29fb8325af06/zlib.h.in#L61 test.test_zlib.CompressObjectTestCase.test_flushes blew up with: Traceback (most recent call last): File "/builddir/build/BUILD/Python-3.12.0/Lib/test/test_zlib.py", line 477, in test_flushes ver = tuple(int(v) for v in zlib.ZLIB_RUNTIME_VERSION.split('.')) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/builddir/build/BUILD/Python-3.12.0/Lib/test/test_zlib.py", line 477, in <genexpr> ver = tuple(int(v) for v in zlib.ZLIB_RUNTIME_VERSION.split('.')) ^^^^^^ ValueError: invalid literal for int() with base 10: 'zlib-ng' This reuses logic from another test. Fixes python#112769
serhiy-storchaka
approved these changes
Dec 5, 2023
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @hroncok for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-112773 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2023
…th non-int suffix (pythonGH-112771) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
GH-112774 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2023
…th non-int suffix (pythonGH-112771) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
Thanks @serhiy-storchaka |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 5, 2023
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 5, 2023
befeleme
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Jan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
befeleme
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Jan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
befeleme
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Jan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
befeleme
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Jan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
befeleme
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Jan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…th non-int suffix (pythonGH-112771) zlib-ng defines the version as "1.3.0.zlib-ng".
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Feb 27, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
hroncok
added a commit
to fedora-python/cpython
that referenced
this pull request
Mar 7, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 11, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 11, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
hrnciar
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
hrnciar
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
hrnciar
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
stratakis
pushed a commit
to stratakis/cpython
that referenced
this pull request
Mar 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
hroncok
added a commit
to fedora-python/cpython
that referenced
this pull request
Mar 26, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
mcepl
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Apr 2, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
encukou
added
3.10
|
Thanks @hroncok for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry, @hroncok and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-119565 is a backport of this pull request to the 3.10 branch. |
|
GH-119566 is a backport of this pull request to the 3.9 branch. |
|
GH-119567 is a backport of this pull request to the 3.8 branch. |
ambv
pushed a commit
that referenced
this pull request
May 30, 2024
ambv
pushed a commit
that referenced
this pull request
May 30, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…th non-int suffix (pythonGH-112771) zlib-ng defines the version as "1.3.0.zlib-ng".
hrnciar
pushed a commit
to fedora-python/cpython
that referenced
this pull request
Sep 9, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774) zlib-ng defines the version as "1.3.0.zlib-ng". (cherry picked from commit d384813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zlib-ng defines the version as "1.3.0.zlib-ng".
https://github.com/zlib-ng/zlib-ng/blob/f3211aba349a1d4781d0d41cb00d29fb8325af06/zlib.h.in#L61
test.test_zlib.CompressObjectTestCase.test_flushes blew up with:
This reuses logic from another test.
Fixes #112769