Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110383: Remove references to removed popen[234] #112783

Merged
merged 4 commits into from
May 30, 2024

Conversation

shenanigansd
Copy link
Contributor

@shenanigansd shenanigansd commented Dec 6, 2023

Continues #110383
Originally reported in https://mail.python.org/archives/list/docs@python.org/thread/4AYZNSW3RB3DNT5C7JEE6RCESBWIKZTD/

Remove recommendations for migrating away from os.popen2, os.popen3, os.popen4, and popen2, which haven't existed since Python 2.7.

Leaves the recommendations for os.popen, which does still exist.


📚 Documentation preview 📚: https://cpython-previews--112783.org.readthedocs.build/

These functions were removed in Python 3.

Signed-off-by: Bradley Reynolds <bradley.reynolds@darbia.dev>
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 6, 2023
@tonybaloney
Copy link
Contributor

They have been commented out since 2009: python@9e4ff75
@shenanigansd
Copy link
Contributor Author

shenanigansd commented Dec 20, 2023

Upon review, that section was commented out in 2009 (9e4ff75)
If it hasn't been needed since then, we should probably go ahead and remove it.

I've gone ahead and removed it in f84d6d4

@encukou encukou enabled auto-merge (squash) May 30, 2024 12:03
@encukou encukou merged commit b1374aa into python:main May 30, 2024
25 checks passed
@shenanigansd shenanigansd deleted the br/remove-references-to-popen+ branch May 30, 2024 15:22
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…2783)


Signed-off-by: Bradley Reynolds <bradley.reynolds@darbia.dev>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…2783)


Signed-off-by: Bradley Reynolds <bradley.reynolds@darbia.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants