GH-111485: Factor out tier 2 code generation from the rest of the interpreter code generator #112968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Dec 11, 2023
•
markshannon
commented
- Issue: The code generated for the interpreter(s) is too fragile #111485
iritkatriel
reviewed
Dec 11, 2023
gvanrossum
reviewed
Dec 12, 2023
| @@ -138,145 +57,6 @@ def declare_variables(inst: Instruction, out: CWriter) -> None: | |||
| out.emit(f"{type}{var.name};\n") | |||
|
|
|||
|
|
|||
| def emit_to(out: CWriter, tkn_iter: Iterator[Token], end: str) -> None: | |||
There was a problem hiding this comment.
Did you make any changes to the code that you moved to generators_common.py or stack.py? Or is it strictly a move?
There was a problem hiding this comment.
It is strictly a move
| @@ -17,3 +33,143 @@ def write_header(generator: str, source: str, outfile: TextIO) -> None: | |||
| // Do not edit! | |||
| """ | |||
| ) | |||
|
|
|||
|
|
|||
| def emit_to(out: CWriter, tkn_iter: Iterator[Token], end: str) -> None: | |||
There was a problem hiding this comment.
This could be a method on CWriter.
There was a problem hiding this comment.
I thought about that, but it tracks the parentheses in the tkn_iter input, which seems out of scope for a writer.
iritkatriel
approved these changes
Dec 12, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…he interpreter code generator (pythonGH-112968)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…he interpreter code generator (pythonGH-112968)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.