-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
gh-112983: Add the known magic value of 3495 for Python 3.11 bytecode #112985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, interesting, I don't think a bad merge is necessary to explain this, just the fact of the backporting process. The PR in main lands first, and it's unnatural there to predict a backport-version bytecode magic number that doesn't exist yet (though I suppose this is the right thing for such a PR to do). The backport PR then adds the backport magic number, but there's nothing in our process that would ever merge that forwards to main again. This would only occur if we backport a backward-incompatible bytecode change after the beta cutoff, which I think we usually prefer not to do. Anyway, adding the missing version certainly seems like the right thing to do. Thanks for the PR! |
@carljm Ah, that makes sense. I see it in the 3.11 branch but not in the 3.12 branch. |
Good call, yes, we should backport this to 3.12 as well. |
…tecode (pythonGH-112985) Add the known magic value of 3495 for Python 3.11 bytecode (cherry picked from commit 616622c) Co-authored-by: wim glenn <jump@wimglenn.com>
GH-113023 is a backport of this pull request to the 3.12 branch. |
…tecode (python#112985) Add the known magic value of 3495 for Python 3.11 bytecode
…tecode (python#112985) Add the known magic value of 3495 for Python 3.11 bytecode
This line from @ambv in 1bfe83a got lost somehow (maybe conflict in #94552?)