Skip to content

bpo-20001: Update pathlib landing image #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2019
Merged

bpo-20001: Update pathlib landing image #11304

merged 2 commits into from
Feb 5, 2019

Conversation

harmands
Copy link
Contributor

@harmands harmands commented Dec 24, 2018 •
edited by bedevere-bot
Loading

@ewdurbin
Copy link
Member

labels removed and readded to test hooks to bugs.python.org

BoboTiG
BoboTiG approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harmands!

LGTM 👍

@methane
Copy link
Member

methane commented Feb 5, 2019

See GH-8032.
Could you try same optipng?

@harmands harmands force-pushed the pathlib_inheritence branch from 35ed742 to 81e279c Compare February 5, 2019 10:08
@harmands
Copy link
Contributor Author

harmands commented Feb 5, 2019

@methane Didn't know about it. Done.

@methane methane added docs Documentation in the Doc dir needs backport to 3.7 labels Feb 5, 2019
@methane
Copy link
Member

methane commented Feb 5, 2019

Thanks,

@methane methane merged commit cd90f6a into python:master Feb 5, 2019
@miss-islington
Copy link
Contributor

Thanks @harmands for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @harmands and @methane, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cd90f6a3692e0f7ef0a13aae651e19a08d1f9b31 3.7

@bedevere-bot
Copy link

GH-11761 is a backport of this pull request to the 3.7 branch.

methane pushed a commit to methane/cpython that referenced this pull request Feb 5, 2019
@harmands @methane
bpo-20001: update pathlib landing image (pythonGH-11304)
b343034 
(cherry picked from commit cd90f6a)
methane added a commit that referenced this pull request Feb 5, 2019
@methane
bpo-20001: update pathlib landing image (GH-11304)
21ab774 
(cherry picked from commit cd90f6a)
@harmands harmands deleted the pathlib_inheritence branch February 5, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoboTiG BoboTiG BoboTiG approved these changes

Assignees

@methane methane

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@harmands @ewdurbin @methane @miss-islington @bedevere-bot @BoboTiG @the-knights-who-say-ni