-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-113149: improve error when json has trailing comma #113227
Merged
serhiy-storchaka
merged 4 commits into
python:main
from
carsonRadtke:cradtke/json-trailing-comma
Dec 17, 2023
Merged
gh-113149: improve error when json has trailing comma #113227
serhiy-storchaka
merged 4 commits into
python:main
from
carsonRadtke:cradtke/json-trailing-comma
Dec 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add news entry * cjson impl * pyjson impl * update tests
carsonRadtke
changed the title
gh-113226: improve error when json has trailing comma
gh-113149: improve error when json has trailing comma
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. Please fix style add add test cases with spaces between comma and closing brace.
serhiy-storchaka
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for your contribution @carsonRadtke. |
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
cjwatson
added a commit
to cjwatson/singledispatch-json
that referenced
this pull request
Nov 13, 2024
The previously-expected messages and indexes were changed by python/cpython#113227. Fixes: domdfcoding#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: gh-113149
Adds two new
JSONDecodeError
types: "Illegal trailing comma before end of {array,object}".Some test's expected error location had to change because the error now exists with the existence of the comma, rather than the non-existence of a following object.
Had to introduce a
Py_ssize_t comma_idx;
because we want to ensure thatBehavior after the PR: