GH-110109: Drop use of new regex features in pathlib._abc
.
#113292
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regex group with a
?+
possessive quantifier was used to match empty paths, which were represented as a single dot, preventing the dot from being matched by other wildcards. This quantifier is only available from Python 3.11+, but pathlib's_abc.py
file will be made available as a PyPI package for Python 3.8+.This commit adds a new private
_pattern_str
property that works like__str__()
but represents empty paths as''
rather than'.'
. This string is used for pattern matching, which removes the need for the possessive group. We also replacere.NOFLAG
with0
, again for backwards-compatibility with older Python.Improves compatibility with older Python; no other change of behaviour.
See external
pathlib_abc
issue: barneygale/pathlib-abc#8