GH-112215: Increase C recursion limit for non debug builds #113397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
added
needs backport to 3.12
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit a8c8eca 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
!buildbot s390.* |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit bbdac94 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
iritkatriel
approved these changes
Dec 22, 2023
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @markshannon, I could not cleanly backport this to |
|
GH-113403 is a backport of this pull request to the 3.12 branch. |
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Dec 22, 2023
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimentation shows that we can safely increase the C recursion limit for non-debug builds considerably.
In hindsight, we should have done this when we introduced the C recursion limit. There is little value in having the same limit for debug and non-debug builds and the low limit needed for debug builds is too restrictive for release builds.
@functools.cache#112215