-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-113267: Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)" #114470
Merged
serhiy-storchaka
merged 2 commits into
python:main
from
serhiy-storchaka:revert-unittest-move-start-test
Feb 4, 2024
Merged
gh-113267: Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)" #114470
serhiy-storchaka
merged 2 commits into
python:main
from
serhiy-storchaka:revert-unittest-move-start-test
Feb 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython#106588)" This reverts commit 8fc0713.
serhiy-storchaka
changed the title
Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)"
gh-113267: Revert "gh-106584: Fix exit code for unittest in Python 3.12 (#106588)"
Jan 23, 2024
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 4, 2024
…in Python 3.12 (pythonGH-106588)" (pythonGH-114470) This reverts commit 8fc0713. (cherry picked from commit ecabff9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-114994 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 4, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…in Python 3.12 (python#106588)" (pythonGH-114470) This reverts commit 8fc0713.
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…in Python 3.12 (python#106588)" (pythonGH-114470) This reverts commit 8fc0713.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8fc0713.
unittest
#106584TestResult.stopTest
called when test is skipped, despiteTestResult.startTest
not being called #113267