gh-114626: add PyCFunctionFast and PyCFunctionFastWithKeywords #114627
Conversation
|
All commit authors signed the Contributor License Agreement. |
There was a problem hiding this comment.
Makes sense to me.
The type names aren't really needed in C code -- you typically just define a function with the given signature -- so they were left out.
The names should be added to Misc/stable_abi.toml (see [typedef.PyCFunction] there.)
This is a limited API; let's play by the book (well, the book we want to write) and let the C-API WG know. (edit: opened issue at capi-workgroup/decisions#11 )
|
@encukou thanks for tidying this up, sorry it was just off the top of my to-do list and I hadn't quite got around to it yet 😞 |
|
No problem! Thanks for bringing it up and starting. |
Python 3.13a4 adds a public PyCFunctionFastWithKeywords type. * python/cpython@9e3729b * python/cpython#114627 * capi-workgroup/decisions#11 Python 3.13a1 removed the private _PyCFunctionFastWithKeywords type.
Python 3.13a4 adds a public PyCFunctionFastWithKeywords type and removes the private _PyCFunctionFastWithKeywords type: * python/cpython@9e3729b * python/cpython#114627 * capi-workgroup/decisions#11
|
FYI PR to update Cython: cython/cython#6003 |
Python 3.13a4 adds a public PyCFunctionFastWithKeywords and PyCFunctionFast types and removes the private _PyCFunctionFastWithKeywords and _PyCFunctionFast types: * python/cpython@9e3729b * python/cpython#114627 * capi-workgroup/decisions#11
…3a4 (GH-6003) Python 3.13a4 adds a public PyCFunctionFastWithKeywords and PyCFunctionFast types and removes the private _PyCFunctionFastWithKeywords and _PyCFunctionFast types: * python/cpython@9e3729b * python/cpython#114627 * capi-workgroup/decisions#11
|
Wait, the old name is |
|
I wrote cython/cython@e9b08d3 to make Cython compatibility with Python 3.13 alpha4. |
I wrote PR #115561 to fix this typo. |
…3a4 (GH-6003) Python 3.13a4 adds a public PyCFunctionFastWithKeywords and PyCFunctionFast types and removes the private _PyCFunctionFastWithKeywords and _PyCFunctionFast types: * python/cpython@9e3729b * python/cpython#114627 * capi-workgroup/decisions#11
Closes #114626
I basically did a find-and-replace, plus added typedefs to keep
_PyCFunctionFastand_PyCFunctionFastWithKeywordsaround for backwards compatibility._PyCFunctionFastand_PyCFunctionFastWithKeywords#114626📚 Documentation preview 📚: https://cpython-previews--114627.org.readthedocs.build/