Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-114709: Fix exceptions raised by posixpath.commonpath #114710

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Jan 29, 2024

Raise ValueError, not IndexError when passed an empty iterable. Raise TypeError, not ValueError when passed None.


📚 Documentation preview 📚: https://cpython-previews--114710.org.readthedocs.build/

Raise ValueError, not IndexError when passed an empty iterable. Raise
TypeError, not ValueError when passed None.
@hauntsaninja hauntsaninja merged commit 371c970 into python:main Feb 18, 2024
33 checks passed
@srittau srittau deleted the commonpath-iter branch February 19, 2024 04:40
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…n#114710)

Fix the exceptions raised by posixpath.commonpath

Raise ValueError, not IndexError when passed an empty iterable. Raise
TypeError, not ValueError when passed None.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…n#114710)

Fix the exceptions raised by posixpath.commonpath

Raise ValueError, not IndexError when passed an empty iterable. Raise
TypeError, not ValueError when passed None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants