Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115114: Add missing slash to file URI prefix file:/ #115115

Merged
merged 1 commit into from
Feb 7, 2024
Merged

gh-115114: Add missing slash to file URI prefix file:/ #115115

merged 1 commit into from
Feb 7, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Feb 7, 2024 •
edited by github-actions bot
Loading

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Feb 7, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Feb 7, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Feb 7, 2024
@barneygale
Copy link
Contributor

barneygale commented Feb 7, 2024 •
edited
Loading

Technically we support URIs like file:c:/foo and file:/c:/foo on Windows, and file:/blah on POSIX, but they're variant formats and not produced by as_uri(). So this change makes sense.

@barneygale barneygale merged commit 60375a3 into python:main Feb 7, 2024
27 checks passed
@edgarrmondragon edgarrmondragon deleted the docs/file-uri-prefix-type branch February 7, 2024 05:39
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@edgarrmondragon @fsc-eriker
pythongh-115114: Add missing slash to file URI prefix file:/ (pytho…
5c1e43e 
…n#115115)

Add missing slash to file URI prefix `file:/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneygale barneygale barneygale approved these changes

@sunmy2019 sunmy2019 sunmy2019 approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarrmondragon @barneygale @sunmy2019