Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115142: Skip test_optimizer if _testinternalcapi module is not available. #115175

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Feb 8, 2024

@serhiy-storchaka serhiy-storchaka merged commit f8931ad into python:main Feb 9, 2024
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 9, 2024
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @Eclips4 and @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f8931adc597aa696a0f60439e8f9a9047d51ef1c 3.11

@miss-islington-app
Copy link

Sorry, @Eclips4 and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f8931adc597aa696a0f60439e8f9a9047d51ef1c 3.12

@Eclips4
Copy link
Member Author

Eclips4 commented Feb 9, 2024

@serhiy-storchaka this test module is not presented in 3.11 & 3.12 branches, so backports here is unneeded.
Thanks for merging!

@Eclips4 Eclips4 deleted the issue-115142-test-optimizer branch February 9, 2024 17:09
@serhiy-storchaka serhiy-storchaka removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 9, 2024
@serhiy-storchaka
Copy link
Member

Well. I always try to backport tests back as far as it is feasible.

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants