gh-82062: correctly set module for built-in instance methods in inspect.signature() #115270
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inspect.signature() The ``__module__`` attribute is missing for instance methods in extension modules, so instead we use in this case ``__objclass__.__module__``.
|
Alternatively, we could set the >>> int.to_bytes.__module__
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'method_descriptor' object has no attribute '__module__'. Did you mean: '__reduce__'? |
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
Show resolved
Hide resolved
|
@serhiy-storchaka, I hope I did requested changes. |
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Apr 30, 2024
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-02-11-07-31-43.gh-issue-82062.eeS6w7.rst
Outdated
Show resolved
Hide resolved
…S6w7.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…sion modules (pythonGH-115270) Now inspect.signature() supports references to the module globals in parameter defaults on methods in extension modules. Previously it was only supported in functions. The workaround was to specify the fully qualified name, including the module name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__module__attribute is missing for instance methods in extension modules, so instead we use in this case__objclass__.__module__.