Skip to content

Revert "bpo-35537: subprocess can now use os.posix_spawnp (GH-11579)" #11582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2019
Merged

Revert "bpo-35537: subprocess can now use os.posix_spawnp (GH-11579)" #11582

merged 1 commit into from
Jan 16, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 16, 2019 •
edited by bedevere-bot
Loading

@vstinner vstinner requested a review from gpshead as a code owner January 16, 2019 22:02
@vstinner
Copy link
Member Author

It seems like I was too excited and merged my PR #11579 too quickly. @izbyshev noticed that my change modified the subprocess behavior:
#11579

Honestly, I don't know if it's ok or not, but I case of doubt, I prefer to simpler revert to have more time to think about the issue.

@vstinner vstinner mentioned this pull request Jan 16, 2019
Merged
@vstinner vstinner merged commit 8c34956 into python:master Jan 16, 2019
@vstinner vstinner deleted the revert branch January 16, 2019 22:38
@izbyshev izbyshev mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @gpshead @the-knights-who-say-ni @bedevere-bot