Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112087: Make list_{subscript, ass_slice, slice} to be thread-safe #115854

Closed
wants to merge 2 commits into from
Closed

gh-112087: Make list_{subscript, ass_slice, slice} to be thread-safe #115854

wants to merge 2 commits into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 23, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 23, 2024
Closed
4 tasks
@corona10
Copy link
Member Author

To port list_ass_slice_impl from nogil implementation, we may need to port also other implementations but it occurs crash in my local so I need more investigation.
https://github.com/colesbury/nogil-3.12/blob/cedde4f5ec3759ad723c89d44738776f362df564/Objects/listobject.c#L101-L136

So before porting all of them, I propose a simpler implementation but not sure that it will be safe or acceptable performance. :)

@corona10 corona10 requested a review from colesbury February 23, 2024 14:24
@corona10 corona10 marked this pull request as draft February 24, 2024 00:12
@corona10
Copy link
Member Author

Hmm let me check more

@corona10
Copy link
Member Author

I will continue to work on this PR after #115875 is merged.

@corona10 corona10 closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury Awaiting requested review from colesbury

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@corona10