Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112075: Remove compiler warning from apple clang #115855

Merged
merged 1 commit into from
Feb 28, 2024
Merged

gh-112075: Remove compiler warning from apple clang #115855

merged 1 commit into from
Feb 28, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 23, 2024 •
edited by bedevere-app bot
Loading

@corona10 corona10 requested review from DinoV and colesbury February 23, 2024 14:57
@bedevere-app bedevere-app bot mentioned this pull request Feb 23, 2024
Closed
@corona10
Copy link
Member Author 

Objects/dictobject.c:5032:9: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
    if (!dictiter_iternext_threadsafe(d, self, &value, NULL) == 0) {

@corona10 corona10 merged commit f58f8ce into python:main Feb 28, 2024
37 checks passed
@corona10 corona10 deleted the gh-112075-clang-warn branch February 28, 2024 17:52
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@corona10 @woodruffw
pythongh-112075: Remove compiler warning from apple clang (pythongh-1…
8486395 
…15855)
@colesbury colesbury mentioned this pull request Mar 4, 2024
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@corona10 @adorilson
pythongh-112075: Remove compiler warning from apple clang (pythongh-1…
104f09c 
…15855)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112075: Remove compiler warning from apple clang (pythongh-1…
baec9b3 
…15855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@DinoV DinoV Awaiting requested review from DinoV

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @colesbury