Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116098: Revert "gh-107674: Improve performance of sys.settrace (GH-114986)" #116178

Merged
merged 1 commit into from
Mar 1, 2024
Merged

gh-116098: Revert "gh-107674: Improve performance of sys.settrace (GH-114986)" #116178

merged 1 commit into from
Mar 1, 2024

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Mar 1, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 1, 2024
Closed
@gaogaotiantian gaogaotiantian requested a review from encukou March 1, 2024 04:05
@gaogaotiantian
Copy link
Member Author

As we are not able to come up with a quick fix for #116098, we'll revert this commit for now and discuss what's the best solution to check the change in. @encukou

@encukou encukou merged commit 7895a61 into python:main Mar 1, 2024
49 checks passed
@gaogaotiantian gaogaotiantian deleted the revert-114986 branch March 2, 2024 02:19
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@gaogaotiantian @woodruffw
pythongh-116098: Revert "pythongh-107674: Improve performance of `sys…
7c194b9 
….settrace` (pythonGH-114986)" (pythonGH-116178)

Revert "pythongh-107674: Improve performance of `sys.settrace` (pythonGH-114986)"

This reverts commit 0a61e23.
@gaogaotiantian gaogaotiantian mentioned this pull request Mar 21, 2024
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@gaogaotiantian @adorilson
pythongh-116098: Revert "pythongh-107674: Improve performance of `sys…
aabeaa5 
….settrace` (pythonGH-114986)" (pythonGH-116178)

Revert "pythongh-107674: Improve performance of `sys.settrace` (pythonGH-114986)"

This reverts commit 0a61e23.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@gaogaotiantian @diegorusso
pythongh-116098: Revert "pythongh-107674: Improve performance of `sys…
25aa06c 
….settrace` (pythonGH-114986)" (pythonGH-116178)

Revert "pythongh-107674: Improve performance of `sys.settrace` (pythonGH-114986)"

This reverts commit 0a61e23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaogaotiantian @encukou