Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116265: Remove obsolete sentence. #116284

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Mar 3, 2024

Remove sentence in Tools/c-analyzer/README referring to ignore-globals.txt,
removed 4 years ago (so also gone in 3.12 and 3.11).

Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
@terryjreedy terryjreedy added docs Documentation in the Doc dir needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Mar 3, 2024
@aisk
Copy link
Member

aisk commented Mar 4, 2024

There is another sentence that mentions ignored-globals.txt at the end of this article. Therefore, I think it should be updated too.

@terryjreedy
Copy link
Member Author

@aisk Thank you. Removed.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

Thanks, @terryjreedy!

@terryjreedy terryjreedy merged commit 88b5c66 into python:main Mar 4, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2024
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2024
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app
Copy link

bedevere-app bot commented Mar 4, 2024

GH-116331 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 4, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 4, 2024

GH-116332 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 4, 2024
@terryjreedy terryjreedy deleted the ctools branch March 4, 2024 21:50
terryjreedy added a commit that referenced this pull request Mar 4, 2024
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Mar 4, 2024
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
(cherry picked from commit 88b5c66)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Remove sentence in Tools/c-analyzer/README referring to deleted
ignore-globals.txt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants