Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116112: Fix ResourceWarning in test_asyncio.test_stream #116371

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 5, 2024

I've done local testing:

» ./python.exe -We -m test test_asyncio.test_streams -m test_unhandled_cancel
Using random seed: 3038344157
0:00:00 load avg: 0.73 Run 1 test sequentially
0:00:00 load avg: 0.73 [1/1] test_asyncio.test_streams

== Tests result: SUCCESS ==

1 test OK.

Total duration: 194 ms
Total tests: run=1 (filtered)
Total test files: run=1/1 (filtered)
Result: SUCCESS

It works. This solution was proposed by @CendioOssman in #116112 (comment)

Co-authored-by: @CendioOssman

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did some local testing too and it seems to work.

@sobolevn
Copy link
Member Author

sobolevn commented Mar 5, 2024

Thank you! 👍

I've merged this, no backports, because #115661 did not have any.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants