-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112536: Add --tsan test for reasonable TSAN execution times. #116601
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
60e7b12
gh-112536: Add --tsan test for reasonable TSAN execution times.
corona10 a0c5961
Update documentation
corona10 4230c92
fix
corona10 a13ecb7
Update
corona10 9a4b5a3
Update Lib/test/libregrtest/main.py
corona10 2df3502
lint
corona10 b3fac0b
Exclude some tests
corona10 d8d2e8b
Adjust more tests
corona10 06607e5
Adjust tests
corona10 0f1899e
Address code review
corona10 ff8c92e
Update Lib/test/libregrtest/tsan.py
corona10 b571b9d
Address code review
corona10 8f28847
Merge remote-tracking branch 'upstream/main' into gh-112536-tsan-tests
corona10 3f265e1
Merge branch 'main' into gh-112536-tsan-tests
corona10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Set of tests run by default if --tsan is specified. The tests below were | ||
# chosen because they use threads and run in a reasonable amount of time. | ||
|
||
TSAN_TESTS = [ | ||
'test_code', | ||
'test_enum', | ||
'test_functools', | ||
'test_httpservers', | ||
'test_imaplib', | ||
'test_importlib', | ||
'test_io', | ||
'test_logging', | ||
'test_ssl', | ||
'test_syslog', | ||
'test_thread', | ||
'test_threadedtempfile', | ||
'test_threading_local', | ||
'test_threadsignals', | ||
] | ||
|
||
|
||
def setup_tsan_tests(cmdline_args): | ||
if not cmdline_args: | ||
cmdline_args[:] = TSAN_TESTS[:] |
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Tests/2024-03-11-23-20-28.gh-issue-112536.Qv1RrX.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Add --tsan to test.regrtest for running TSAN tests in reasonable execution | ||
times. Patch by Donghee Na. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
## reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am going to update the list of supressions.txt when working on the CI things. |
||
race:get_allocator_unlocked | ||
race:set_allocator_unlocked | ||
race:mi_heap_visit_pages | ||
race:_mi_heap_delayed_free_partial |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swtaarrs It will be the more clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I completely missed this notification. Looks good to me :)