-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-116858: Add @cpython_only
to several tests in test_cmd_line
#116859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you! This is helpful! |
I have some experience in "porting" tests from CPython to RustPython and this PR seems great! Thanks, Nikita. |
Also, I would like to backport these changes to 3.11 & 3.12 branches. What do you think about this, Nikita? |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @sobolevn, I could not cleanly backport this to
|
Sorry, @sobolevn, I could not cleanly backport this to
|
I will do the backports manually! 👍 |
GH-116889 is a backport of this pull request to the 3.12 branch. |
GH-116890 is a backport of this pull request to the 3.11 branch. |
List of tests and reasoning:
test_help
,test_help_env
,test_help_xoptions
,test_help_all
make assumptions about the exact output of help, which might not be the case for other implementations. They can show help as tables / with-X
prefix, or whatevertest_version
explicitly tests that it starts withPython
(it might beRustPython
for other implementaions)test_env_var_frozen_modules
andtest_xoption_frozen_modules
uses frozenmodules, which a basically our internal implementation detail that uses C partstest_unknown_options
expects a very specific error messagetest_xdev
usesmalloc
checks insideCC @youknowone from RustPython, it might be interesting to you.
test_cmd_line
ascpython_only
#116858