Skip to content

gh-116858: Add @cpython_only to several tests in test_cmd_line #116859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 15, 2024

List of tests and reasoning:

  • test_help, test_help_env, test_help_xoptions, test_help_all make assumptions about the exact output of help, which might not be the case for other implementations. They can show help as tables / with -X prefix, or whatever
  • test_version explicitly tests that it starts with Python (it might be RustPython for other implementaions)
  • test_env_var_frozen_modules and test_xoption_frozen_modules uses frozenmodules, which a basically our internal implementation detail that uses C parts
  • test_unknown_options expects a very specific error message
  • test_xdev uses malloc checks inside

CC @youknowone from RustPython, it might be interesting to you.

@youknowone
Copy link
Contributor

Thank you! This is helpful!

@Eclips4
Copy link
Member

Eclips4 commented Mar 15, 2024

I have some experience in "porting" tests from CPython to RustPython and this PR seems great! Thanks, Nikita.

@Eclips4
Copy link
Member

Eclips4 commented Mar 15, 2024

Also, I would like to backport these changes to 3.11 & 3.12 branches. What do you think about this, Nikita?

@gpshead gpshead added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 15, 2024
@sobolevn sobolevn merged commit a1c4923 into python:main Mar 16, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a1c4923d65a3e4cea917745e7f6bc2e377cde5c5 3.12

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a1c4923d65a3e4cea917745e7f6bc2e377cde5c5 3.11

@sobolevn
Copy link
Member Author

I will do the backports manually! 👍

sobolevn added a commit to sobolevn/cpython that referenced this pull request Mar 16, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 16, 2024

GH-116889 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 16, 2024
sobolevn added a commit to sobolevn/cpython that referenced this pull request Mar 16, 2024
@bedevere-app
Copy link

bedevere-app bot commented Mar 16, 2024

GH-116890 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 16, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants