gh-106531: Apply changes from importlib_resources 6.3.2 #117054
Conversation
jaraco
commented
Mar 20, 2024
•
jaraco
commented
- Issue: Refresh importlib.resources #106531
jaraco
requested review from
warsaw,
FFY00,
brettcannon,
ericsnowcurrently and
ncoghlan
as code owners
jaraco
force-pushed
the
gh-106531/refresh-importlib_resources-6.3.2
branch
2 times, most recently
from
2e9212f to
98465e0
Compare
jaraco
force-pushed
the
gh-106531/refresh-importlib_resources-6.3.2
branch
from
98465e0 to
be08256
Compare
|
Well shoot. I'd meant for this to land in Python 3.13, but lost track of it. @Yhg1s would you be willing to allow this to land in 3.13b2? It does add a deprecation for a usage that's likely rare. |
|
I was thinking about this overnight and I'm going to take the executive decision to merge it and back-port it, knowing that we might decide to delay the deprecation, especially if there's more than a small impact (which I don't expect). |
|
On further consideration, after re-reading the summary in the blurb and looking at the diff, I'm reminded that this change is about much more than just the introduced deprecation. Still, I want to get this merged and we can discuss the viability of the backport in the backport PR. |
|
Given that this is effectively syncing with a newer version of importlib_resources, I'm okay with this going into 3.13 at this point. |
|
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…GH-117054) Apply changes from importlib_resources 6.3.2. (cherry picked from commit 8d63c8d) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
|
GH-120014 is a backport of this pull request to the 3.13 branch. |
…#117054) Apply changes from importlib_resources 6.3.2.
…#117054) Apply changes from importlib_resources 6.3.2.
…#117054) Apply changes from importlib_resources 6.3.2.
