Skip to content

Conversation

@cocoatomo
Copy link
Contributor

These are just miscellaneous fixes.

@mention-bot
Copy link

@cocoatomo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @doko42 and @tiran to be potential reviewers.

@Mariatta Mariatta merged commit 992ae64 into python:master Apr 19, 2017
@Mariatta
Copy link
Member

Thanks :)

@cocoatomo cocoatomo deleted the minor-typos branch April 19, 2017 00:45
-------------

The :mod:`select` and contains the following notice for the kqueue interface::
The :mod:`select` contains the following notice for the kqueue interface::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still isn't quite right, it now reads "The select contains the following ...", which is nonsensical. Either remove the leading 'The', or (preferably) add 'module' after select.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that 😞 Fixed here: #1174

@terryjreedy
Copy link
Member

Doc changes should be backported, at least to maintained 3.x versions. Miss Islington makes this usually easier now ;-). bpo-32664 is a report of the missing '|' in Lib/test/exception_hierarchy.txt. (Not an issue in 2.7.) This should be fixed in 3.6.

I could just add the 3.6 backport tag, but then there would be the incorrect fix to Doc/license.rst. That could then be fixed by tagging #1174, but I don't know if you think this the best thing to do.

@Mariatta
Copy link
Member

Hmm, ok I think we can backport both: this PR first, then followed by backport of GH-1174

@miss-islington
Copy link
Contributor

Thanks @cocoatomo for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2018
(cherry picked from commit 992ae64)
@bedevere-bot
Copy link

GH-5372 is a backport of this pull request to the 3.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants