-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Fix minor typos #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor typos #1173
Conversation
|
@cocoatomo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @doko42 and @tiran to be potential reviewers. |
|
Thanks :) |
| ------------- | ||
|
|
||
| The :mod:`select` and contains the following notice for the kqueue interface:: | ||
| The :mod:`select` contains the following notice for the kqueue interface:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still isn't quite right, it now reads "The select contains the following ...", which is nonsensical. Either remove the leading 'The', or (preferably) add 'module' after select.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that 😞 Fixed here: #1174
|
Doc changes should be backported, at least to maintained 3.x versions. Miss Islington makes this usually easier now ;-). bpo-32664 is a report of the missing '|' in Lib/test/exception_hierarchy.txt. (Not an issue in 2.7.) This should be fixed in 3.6. I could just add the 3.6 backport tag, but then there would be the incorrect fix to Doc/license.rst. That could then be fixed by tagging #1174, but I don't know if you think this the best thing to do. |
|
Hmm, ok I think we can backport both: this PR first, then followed by backport of GH-1174 |
|
Thanks @cocoatomo for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
(cherry picked from commit 992ae64)
|
GH-5372 is a backport of this pull request to the 3.6 branch. |
These are just miscellaneous fixes.