Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-116380: Add tests for glob.glob0() and glob.glob1(). #117305

Closed

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Mar 27, 2024

These undocumented functions expand a single literal or (non-recursive) wildcard segment.

These undocumented functions expand a single literal or (non-recursive)
wildcard segment.
@serhiy-storchaka
Copy link
Member

They are undocumented and no longer used in the stdlib. glob.escape() and the root_dir parameter make them obsolete.

@barneygale
Copy link
Contributor Author

Indeed. But they're used by third-party code, and neither deprecated nor underscore-prefixed.

@serhiy-storchaka
Copy link
Member

They are not underscored because this is not needed.

Opened #117337.

@barneygale
Copy link
Contributor Author

Does deprecating these functions preclude the addition of tests in your view?

@serhiy-storchaka
Copy link
Member

The new tests LGTM. Some tests will be needed for deprecation anyway. But all tests added in this PR will be changed, and maybe moved to other place. This will only increase the size of the logs.

Would you mind creating a PR to deprecate these functions, along with adding new tests? Or do you prefer merging this PR first?

@barneygale
Copy link
Contributor Author

Good shout. I've opened #117371 to deprecate the functions, and incorporated the tests there. I'll close this PR!

@barneygale barneygale closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants