-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117398: datetime: Make use of C-API capsules for sub-interpreters #117413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonene
requested review from
pganssle,
abalkin,
ericsnowcurrently,
markshannon and
gvanrossum
as code owners
April 1, 2024 05:08
Eclips4
reviewed
Apr 1, 2024
Eclips4
reviewed
Apr 1, 2024
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
I'm especially interested to know what @pganssle thinks. |
I have made this the same as #118357 except that this PR caches capi-pointers in the global C array rather than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sub-interpreters to access their C-API by calling
PyCapsule_Import
function every time. Performance could be recovered by client's local caching. The_zoneinfo
extension could also improve a few C-API accesses, if necessary.UPDATE: Tuned for a sub-interpreter: #117413 (comment)
cc @erlend-aasland @ericsnowcurrently