Skip to content

gh-117953: Always Run Extension Init Func in Main Interpreter First #117487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Apr 2, 2024

@ericsnowcurrently ericsnowcurrently changed the title Always Run Extension Init Func in Main Interpreter First gh-117953: Always Run Extension Init Func in Main Interpreter First Apr 16, 2024
@neonene
Copy link
Contributor

neonene commented Apr 18, 2024

I tried this PR on Windows. The following two results were unexpected to me:

...
>>> _xxsubinterpreters.run_string(i, "import _datetime; print(_datetime)")

<module '_datetime' (built-in)>  # legacy module is imported?
...
>>> _xxsubinterpreters.run_string(i, "import _testcapi")
>>> _xxsubinterpreters.destroy(i)

Debug memory block at address p=0000000002EB8B90: API ' '
    15987178197214944733 bytes originally requested
    The 7 pad bytes at p-7 are not all FORBIDDENBYTE (0xfd):
        at p-7: 0x00 *** OUCH
        at p-6: 0x00 *** OUCH
        at p-5: 0x00 *** OUCH
        ...

@ericsnowcurrently
Copy link
Member Author

Thanks for trying it. That info is helpful. FYI, I'm working on extra changes here as the current PR appears to be incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants