Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117752: Autoconf: fix -fno-semantic-interposition check #117789

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 11, 2024

Force the compiler to issue an error if the flag is not supported.

Force the compiler to issue an error if the flag is not supported.
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 11, 2024

There are a couple of other AX_CHECK_COMPILE_FLAG checks in configure.ac; we should make sure all of them are handled like this.

For the linked issue, this should suffice.

@erlend-aasland
Copy link
Contributor Author

I'm going to merge this later today (CET) to give Donghee a chance to review it :)

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews, Donghee :)

@erlend-aasland erlend-aasland merged commit 49fc141 into python:main Apr 12, 2024
39 checks passed
@erlend-aasland erlend-aasland deleted the autoconf/fix-no-semantic-interposition-check branch April 12, 2024 07:37
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2024
…honGH-117789)

Force the compiler to issue an error if the flag is not supported.
(cherry picked from commit 49fc141)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Apr 12, 2024

GH-117800 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 12, 2024
erlend-aasland added a commit that referenced this pull request Apr 12, 2024
…-117789) (#117800)

Force the compiler to issue an error if the flag is not supported.
(cherry picked from commit 49fc141)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…hon#117789)

Force the compiler to issue an error if the flag is not supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants