-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117587: Add C implementation of os.path.abspath
#117855
Conversation
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
The same approach doesn't work on Window, because PS C:\Users\wanne\cpython> python -m timeit -s "import nt" "nt._getfullpathname('.')"; python -m timeit -s "import os" "os.path.join(r'C:\Users\wanne\cpython', '')"
1000000 loops, best of 5: 286 nsec per loop # _getfullpathname
200000 loops, best of 5: 1.41 usec per loop # join |
This comment was marked as resolved.
This comment was marked as resolved.
I didn't even get that far in the testing process. I already knew it wasn't going to work. |
…endo/cpython into speedup-posixpath.abspath
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
erlend-aasland, I have made the requested changes; please review again. |
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Benchmark
posixpath.py by @eryksun:
ntpath.py
script
posixpath.abspath()
for relative paths #117587