Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117873: Use positional-only parameters in os.path #118035

Closed
wants to merge 3 commits into from

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 18, 2024

The parameters of these private functions become positional-only:

  • _path_isdevdrive()
  • _getvolumepathname()
  • _path_splitroot()
  • _path_normpath()
  • _getdiskusage()
  • _add_dll_directory()
  • _remove_dll_directory()

Note: _path_isdir(), _path_isfile(), _path_exists(), _path_islink() & _exit() are public, and continue to accept keyword arguments.

@nineteendo
Copy link
Contributor Author

@AlexWaygood, could you add the skip-news label?

@nineteendo nineteendo marked this pull request as ready for review April 18, 2024 10:34
@nineteendo nineteendo marked this pull request as draft April 18, 2024 12:01
@nineteendo
Copy link
Contributor Author

Converting to draft until I have confirmation if METH_O is faster than METH_FASTCALL | METH_KEYWORDS

@nineteendo nineteendo closed this Apr 19, 2024
@nineteendo nineteendo deleted the speedup-os.path branch April 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants