gh-117398: datetime: Use wrappers for C-API functions #118115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the following wrapper functions for the public C-API, so that the wrapped functions (`_capi` un-suffixed) can have more arguments, such as a module state: * `new_datetime_ex_capi()` * `new_time_ex_capi()`, renamed from `new_time_ex`, as it is internally unused. * `new_timezone_capi()` * `new_datetime_ex2_capi()` * `new_time_ex2_capi()` The wrappers need to get a module state from the C-API class or a given object's type.
vstinner
reviewed
Apr 20, 2024
Modules/_datetimemodule.c
Outdated
| @@ -1047,6 +1047,24 @@ new_datetime_ex(int year, int month, int day, int hour, int minute, | |||
| tzinfo, 0, type); | |||
| } | |||
|
|
|||
| static PyObject * | |||
| new_datetime_ex_capi(int year, int month, int day, int hour, int minute, | |||
There was a problem hiding this comment.
I don't think that "_ex" is useful. Just rename it to "new_datetime_capi", no? Same remark for other functions.
There was a problem hiding this comment.
Your suggestion includes non-capi functions?
|
87408a9 is an attempt to strip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the following wrapper functions for the public C-API, so that the wrapped functions can have more arguments, such as a module state:
new_datetime_nofold_capi()wraps thenew_datetime_exfuncionnew_time_nofold_capi(), renamed fromnew_time_ex, as it is internally unused.new_timezone_capi()wraps thenew_timezonefuncionnew_datetime_capi()wraps thenew_datetime_ex2funcionnew_time_capi()wraps thenew_time_ex2funcionnew_date_capi()wraps thenew_date_exfunctionnew_delta_capi()wraps thenew_delta_exfunctiondatetime_fromtimestamp_capi()wraps thedatetime_fromtimestampfunctionSubsequently, some internal
*_ex?()functions are renamed as well.The wrappers need to get a module state from the C-API class or a given object's type.
cc @vstinner @erlend-aasland: I'd like to prepare as much as possible.