Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118074: Immortal executors are not GC-able #118182

Merged
merged 1 commit into from
Apr 23, 2024
Merged

gh-118074: Immortal executors are not GC-able #118182

merged 1 commit into from
Apr 23, 2024

Conversation

gvanrossum
Copy link
Member

Better version of gh-118117. Just check for immortality instead of an address range check.

@gvanrossum gvanrossum added skip issue skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 23, 2024
@gvanrossum gvanrossum requested a review from markshannon April 23, 2024 15:35
@gvanrossum gvanrossum mentioned this pull request Apr 23, 2024
Merged
markshannon
markshannon approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gvanrossum gvanrossum merged commit 7e87d30 into python:main Apr 23, 2024
54 of 58 checks passed
@gvanrossum gvanrossum deleted the better-cold-exit-fix branch April 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

@markshannon markshannon markshannon approved these changes

@szef1233 szef1233 szef1233 approved these changes

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gvanrossum @eamanu @markshannon @szef1233