Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118418: Use a default value for type_params in typing._eval_type #118431

Merged
merged 1 commit into from
Apr 30, 2024
Merged

gh-118418: Use a default value for type_params in typing._eval_type #118431

merged 1 commit into from
Apr 30, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 30, 2024 •
edited by bedevere-app bot
Loading

This is a way for libs using undocumented and protected _eval_type not to fail with newly added function parameter.

@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2024
Closed
@sobolevn
Copy link
Member Author

Do you have a prefence: should we add a NEWS entry? On one hand, this is a bugfix, on the other hand, _eval_type is private.

@JelleZijlstra
Copy link
Member

Do you have a prefence: should we add a NEWS entry? On one hand, this is a bugfix, on the other hand, _eval_type is private.

I think we don't need to since we never released the (arguably) broken version.

AlexWaygood
AlexWaygood approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

@AlexWaygood AlexWaygood added the needs backport to 3.12 bug and security fixes label Apr 30, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) April 30, 2024 15:39
@AlexWaygood AlexWaygood merged commit 4a5ad84 into python:main Apr 30, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2024
@sobolevn @miss-islington
pythongh-118418: Use a default value for type_params in `typing._ev…
2983ad6 
…al_type` (pythonGH-118431)

(cherry picked from commit 4a5ad84)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Apr 30, 2024

GH-118436 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 30, 2024
AlexWaygood pushed a commit that referenced this pull request Apr 30, 2024
@miss-islington @sobolevn
[3.12] gh-118418: Use a default value for type_params in `typing._e…
0586d54 
…val_type` (GH-118431) (#118436)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@sobolevn @SonicField
pythongh-118418: Use a default value for type_params in `typing._ev…
e2854ce 
…al_type` (python#118431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @JelleZijlstra @AlexWaygood