Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117953: Track Extra Details in Global Extensions Cache #118532

Merged
merged 24 commits into from
May 4, 2024
Merged

gh-117953: Track Extra Details in Global Extensions Cache #118532

merged 24 commits into from
May 4, 2024

Commits on May 3, 2024

  1. Store the cached def in a wrapping struct rather than directly.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1fc1149 View commit details
    Browse the repository at this point in the history

  2. Pass the cached value around where appropriate.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    254e1f1 View commit details
    Browse the repository at this point in the history

  3. Pass the cached value to check_singlephase().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0694318 View commit details
    Browse the repository at this point in the history

  4. Add extensions_cache_value helpers.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9ca330b View commit details
    Browse the repository at this point in the history

  5. Add get_cached_m_dict().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7e0c4ee View commit details
    Browse the repository at this point in the history

  6. Track ext module origin.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c1c1379 View commit details
    Browse the repository at this point in the history

  7. Look up core module dicts in get_cached_m_dict().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8485fb5 View commit details
    Browse the repository at this point in the history

  8. Pass m_dict to _extensions_cache_set().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    abbddde View commit details
    Browse the repository at this point in the history

  9. Pass m_init to _extensions_cache_set().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    12bcd96 View commit details
    Browse the repository at this point in the history

  10. Add some comments.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2d56ada View commit details
    Browse the repository at this point in the history

  11. Use del_cached_m_dict() in set_cached_m_dict().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9c70d53 View commit details
    Browse the repository at this point in the history

  12. Add m_init and m_dict fields to extensions_cache_value.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0098057 View commit details
    Browse the repository at this point in the history

  13. Track which interpreter was used to create m_dict.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    57aaba2 View commit details
    Browse the repository at this point in the history

  14. Track the interpreter ID.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    96932eb View commit details
    Browse the repository at this point in the history

  15. Look up core module dicts in get_cached_m_dict().

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a4cb134 View commit details
    Browse the repository at this point in the history

  16. Make sure we only set m_dict for non-isolated interpreters.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c4d3be1 View commit details
    Browse the repository at this point in the history

  17. Simplify.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d87584d View commit details
    Browse the repository at this point in the history

  18. Fix a comment.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    336d1da View commit details
    Browse the repository at this point in the history

  19. Separate the def logic from the rest of the extensions cache code.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bd1e134 View commit details
    Browse the repository at this point in the history

  20. Add the per-interpreter cache index to each global cache entry.

    @ericsnowcurrently
    ericsnowcurrently committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e42e797 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Fix an assert.

    @ericsnowcurrently
    ericsnowcurrently committed May 4, 2024
    Configuration menu
    Copy the full SHA
    faa4254 View commit details
    Browse the repository at this point in the history

  2. Properly sync the cached m_index and the def m_index.

    @ericsnowcurrently
    ericsnowcurrently committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5276981 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into extensions-cache-better-tracking

    @ericsnowcurrently
    ericsnowcurrently authored May 4, 2024
    Configuration menu
    Copy the full SHA
    f9a2a05 View commit details
    Browse the repository at this point in the history

  4. Fix make smelly.

    @ericsnowcurrently
    ericsnowcurrently committed May 4, 2024
    Configuration menu
    Copy the full SHA
    7d3dbc1 View commit details
    Browse the repository at this point in the history