-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-74929: Rudimentary docs for PEP 667 #118581
Conversation
There's a minor technicality here that might worth clarification. import sys
frame1 = [sys._getframe() for a in [0]][0]
frame2 = sys._getframe()
assert frame1 is frame2
local1 = [sys._getframe().f_locals for a in [0]][0]
local2 = sys._getframe().f_locals
assert local1 != local2 Whether As you can tell from the example above, the |
That's very subtle. Is it explained in PEP 667? I'm not sure how to work this in the existing (pretty sparse) docs for |
Actually the final behavior we agreed on is slightly different from what PEP 667 proposed. PEP 667 also did not mention how |
Assuming this is about clarifying something that the original text of the PEP did not specify precisely enough, and given that the PEP is brand new, I think it's okay to clarify in the PEP. Although in general PEPs are nowadays seen as historic documents, not as living specifications. |
It's not something that has to be done in this PR, but if we think that there are some subtleties here that warrant detailed explanation and that the datamodel docs aren't the right place to do that, one option would be to add a howto similar to the one Larry added in 3.10 to explain the semantics of the It wouldn't really be a howto in the Diataxis sense of the term, but we don't really have a better place for that kind of in-depth article in the CPython docs currently, and there are lots of other articles in that directory that also don't meet Diataxis's strict definition of a "howto" article. And as @gvanrossum says, all the relevant information regarding the semantics here should ideally be findable in the CPython docs somewhere, without having to refer to the PEP, which is a historical document now that it has been accepted. (But we can probably update the PEP as well, given that it's only just been accepted :-) |
@AlexWaygood @gaogaotiantian Are you two okay with me merging this? I'm all for iterating later, but I feel it's important to mention at least this much in the beta 1 docs, which I expect will reach a relatively big audience of people who are thinking of testing the beta. |
Yes this feels okay for beta. |
@@ -87,6 +87,11 @@ Interpreter improvements: | |||
Performance improvements are modest -- we expect to be improving this | |||
over the next few releases. | |||
|
|||
* :pep:`667`: :attr:`FrameType.f_locals <frame.f_locals>` when used in | |||
a function now returns a write-through proxy to the frame's locals, | |||
rather than a ``dict``. See the PEP for corresponding C API changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than a ``dict``. See the PEP for corresponding C API changes | |
rather than a :class:`dict`. See the PEP for corresponding C API changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be a case of over-linking. Surely readers who know what f_locals is will be familiar with dict
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I don't feel strongly, feel free to ignore
Misc/NEWS.d/next/Core and Builtins/2024-04-27-21-44-40.gh-issue-74929.C2nESp.rst
Outdated
Show resolved
Hide resolved
If the frame refers to a function or comprehension, | ||
this may return a write-through proxy object. | ||
|
||
.. versionchanged:: 3.13 | ||
Return a proxy for functions and comprehensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And apparently this also applies for type parameter scopes? Though I have no idea if that was deliberate:
>>> import sys
>>> type T[X: type(sys._getframe().f_locals)] = ...
>>> T.__type_params__[0].__bound__
<class 'FrameLocalsProxy'>
This is *not* sufficient for the final 3.13 release, but it will do for beta 1: - What's new entry - Updated changelog entry (news blurb) - Mention the proxy for f_globals in the datamodel and Python frame object docs This doesn't have any C API details (what's new refers to the PEP).
This is not sufficient for the final 3.13 release, but it may have to do for beta 1:
This doesn't have any C API details (what's new refers to the PEP).
For some reason I cannot get the "versionchanged" note in the datamodel docs to show. @hugovk ?📚 Documentation preview 📚: https://cpython-previews--118581.org.readthedocs.build/